Merged
Conversation
There seems to be a process to publish the module that renames the bundle-esm.js file to bundle.js. I don't know why we need to name the webpack generated file with the -esm suffix.
ekynoxe
force-pushed
the
fix/bundle-file-for-tests
branch
from
5ba1970 to
f62bdd3
Compare
Merged
Member
|
Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either. |
Author
I'm afraid we've had zero feedback from the maintainers on either of my PRs, so we can't do much anymore. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser tests are filing as the bundle file Karma tries to load is not found and frontend tests fail to even start.
It looks like the issue was introduced by #516 and I'm not sure what it aimed to solve since the esbuild generated file is bundle.esm.js, whilst the webpack one was bundle-esm.js (simply bundle.js with this PR.)
I think the file rename was unnecessary, so I've reverted that.
We could also update the karma configuration file to use bundle-esm.js, it fixes the browser tests as well.